Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rdesktop 1.8.4 doesn't build against libressl 2.6 #308

Closed
jo77ah opened this issue Jan 29, 2019 · 2 comments
Closed

rdesktop 1.8.4 doesn't build against libressl 2.6 #308

jo77ah opened this issue Jan 29, 2019 · 2 comments
Labels
wontfix
Milestone
rdesktop-1.9.0

Comments

@jo77ah
Copy link

jo77ah commented Jan 29, 2019

bd6aa6a introduces a guard for RSA_get0_key. this guard doesn't work for libressl, since it sets the version number to 0x20000...
to fix this you need to test defined(LIBRESSL_VERSION_NUMBER).

I'm not sure, if this is relevant for a bug fix release. But it will most certainly be irrelevant for 1.9, if #298 lands.

There is a patch available in gentoo: https://664202.bugs.gentoo.org/attachment.cgi?id=563060
@hean01-cendio
Copy link
Contributor

@jo77ah I'm working on the last parts of GnuTLS to get it included in rdesktop 1.9.0.

@hean01-cendio hean01-cendio added this to the rdesktop-1.9.0 milestone Jan 31, 2019
@hean01-cendio
Copy link
Contributor

Closing this issue due to rdesktop is now using GnuTLS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wontfix
Projects
None yet
Milestone
rdesktop-1.9.0
Development

No branches or pull requests
2 participants
@jo77ah @hean01-cendio