Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make progress output optional, perhaps through a flag #57

Closed
LaurensRietveld opened this issue Jan 27, 2017 · 5 comments
Closed

Make progress output optional, perhaps through a flag #57

LaurensRietveld opened this issue Jan 27, 2017 · 5 comments
Milestone

Comments

@LaurensRietveld
Copy link
Member

What about making the progress output of the cmd line clients optional?
E.g., adding --progress/-p flag to show the progress.
Imo, the cmd clients are more usable with the progress output disabled by default.

@wouterbeek
Copy link
Contributor

Is -v / --verbose not a more standard way of implementing this functionality?

@mielvds
Copy link
Member

mielvds commented Jan 27, 2017

now that we are on the subject, maybe the default should be this: http://www.ross.click/2011/02/creating-a-progress-bar-in-c-or-any-other-console-app/

@LaurensRietveld
Copy link
Member Author

Was thinking about that as well. Verbose would imply this being a larger task though (there are many many maaaany other statements that we'd need to hide/show depending on this flag).
Other than that, the user is not necessarily interested in both the debug msgs and the progress bar. If you look at rsync, that seems to have boththe --progress flag, and the -v flags.

w.r.t. the progress bar itself: yes, that's a very nice way of visualizing it. It shouldnt be that much work (given the implementation of the progressbar in HDT is well thought out). But guess something like that is better suited as a different issue for now.

@mielvds mielvds added this to the Late 2017 milestone Feb 6, 2017
@RubenVerborgh RubenVerborgh changed the title Optional progress output Make progress output optional, perhaps through a flag Jul 9, 2017
@drobilla
Copy link
Contributor

drobilla commented Jul 9, 2017

I went with both in #79. The verbose implementation is shallow, but at least silences the output in typical runs of rdf2hdt and hdt2rdf. Doing this throughout the library would require real logging work and passing handles around and so on.

@RubenVerborgh
Copy link
Member

Following up in #79.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants