Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation problem in develop #66

Closed
webdata opened this issue May 31, 2017 · 8 comments
Closed

Compilation problem in develop #66

webdata opened this issue May 31, 2017 · 8 comments
Assignees
Labels

Comments

@webdata
Copy link
Contributor

webdata commented May 31, 2017

Introduced in:
686e25d

@webdata webdata added the bug label May 31, 2017
@RubenVerborgh
Copy link
Member

Why is this in develop already :-(
Should have remained in long-dict-id until the build was fixed.

@RubenVerborgh
Copy link
Member

Related: #63 / #63 (comment)

@webdata
Copy link
Contributor Author

webdata commented May 31, 2017

No no this compilation problem is not related to the long-dict-id, and long-dict-id has not been merged into develop yet :) Sure, let's fix this problem first

@RubenVerborgh
Copy link
Member

Indeed, I see!

Hmm, after the failing commit 686e25d, nothing else should have been done on develop except for fixing the build again. Travis detected the build failure. @MarioAriasGa Do you receive these failure notifications by mail?

@MarioAriasGa
Copy link
Member

Sorry, I don't receive travis emails, can you please add me?

I will look into this issue. I think it is probably due to the unordered_map being so different between compilers.

@RubenVerborgh
Copy link
Member

@MarioAriasGa I think you just need to register at https://travis-ci.org/, and the rest happens automatically since this project is already on Travis CI.

@RubenVerborgh
Copy link
Member

This issue should be fixed with high priority; we currently cannot build other features on top of develop.

@MarioAriasGa Could you give an estimate for a fix? Otherwise, I'll need to roll back develop to the last working version 2ca11fe and place the current work in progress in a separate branch.

@RubenVerborgh
Copy link
Member

I reset develop to the last working commit 7a067ab and pushed the broken branch to develop-broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants