allow saving and loading in ast format #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, I like it, personally. It should be fairly easy to integrate with atom with this. |
|
@jimfleming yeah, I think I can get my emacs plugin working pretty easily with it. |
| @@ -90,6 +92,10 @@ function handleJavascript(fullPath, original) { | |||
| var js = original; | |||
| var relativePath = path.relative(process.cwd(), fullPath); | |||
|
|
|||
| if (argv['--ast']) { | |||
| js = jsfmt.parseAST(JSON.parse(js)); | |||
There was a problem hiding this comment.
Do we want a try/catch here or just let it error?
|
One comment above but it looks good to me. The action-word is more clear too ( |
|
@jimfleming think this is good, I added try/catch around ast json parsing. |
|
👍 Thanks! |
jimfleming
added a commit
that referenced
this pull request
Aug 7, 2014
allow saving and loading in ast format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jimfleming, this was my attempt at trying to support loading/saving as AST, I dont expect it to be perfect, but a random attempt.
tries to take care of #102