Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(temporal-set): Code did not match spec #89

Merged
merged 3 commits into from
May 11, 2023
Merged

Conversation

jlacivita
Copy link
Collaborator

@jlacivita jlacivita commented May 3, 2023

Updating temporal-set methods to match the spec, e.g.:

interface VolumeProcess {
    stop(): void // Stops updating this temporal set with Volume objects
}

// Live-updated list
function volumes(query: Volume, add: (volume: Volume) => void, remove: (volume: Volume) => void ): VolumeProcess

// First match
function volumes(query: Volume, timeout: number): Promise<Volume>

// Last known list
function volumes(query: Volume): Promise<Volume[]>

@jlacivita jlacivita marked this pull request as draft May 3, 2023 19:17
@jlacivita jlacivita marked this pull request as ready for review May 9, 2023 16:41
@jlacivita jlacivita merged commit e3069f1 into next May 11, 2023
3 checks passed
jlacivita pushed a commit that referenced this pull request May 19, 2023
# [2.0.0-next.3](v2.0.0-next.2...v2.0.0-next.3) (2023-05-19)

### Bug Fixes

* Bug in readText ([b54597b](b54597b))
* Document provider notifications ([4515ff0](4515ff0))
* **Events:** Support for multiple context parameters ([43d8318](43d8318))
* **property:** Copy manage or use caps from getter to setter ([41cb22e](41cb22e))
* Remove unused macro ([9f9b538](9f9b538))
* **temporal-set:** Code did not match spec ([e3069f1](e3069f1)), closes [#89](#89)
* **temporal-set:** Code did not match spec ([00fbae3](00fbae3))
@jlacivita
Copy link
Collaborator Author

🎉 This PR is included in version 2.0.0-next.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

jlacivita pushed a commit that referenced this pull request May 19, 2023
## [2.0.1-next.1](v2.0.0...v2.0.1-next.1) (2023-05-19)

### Bug Fixes

* Bug in readText ([b54597b](b54597b))
* Document provider notifications ([4515ff0](4515ff0))
* **Events:** Support for multiple context parameters ([43d8318](43d8318))
* **property:** Copy manage or use caps from getter to setter ([41cb22e](41cb22e))
* Remove unused macro ([9f9b538](9f9b538))
* **temporal-set:** Code did not match spec ([e3069f1](e3069f1)), closes [#89](#89)
* **temporal-set:** Code did not match spec ([00fbae3](00fbae3))
@jlacivita
Copy link
Collaborator Author

🎉 This PR is included in version 2.0.1-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

jlacivita pushed a commit that referenced this pull request May 19, 2023
## [2.0.1](v2.0.0...v2.0.1) (2023-05-19)

### Bug Fixes

* Bug in readText ([b54597b](b54597b))
* Document provider notifications ([4515ff0](4515ff0))
* **Events:** Support for multiple context parameters ([43d8318](43d8318))
* **property:** Copy manage or use caps from getter to setter ([41cb22e](41cb22e))
* Remove unused macro ([9f9b538](9f9b538))
* **temporal-set:** Code did not match spec ([e3069f1](e3069f1)), closes [#89](#89)
* **temporal-set:** Code did not match spec ([00fbae3](00fbae3))
@jlacivita
Copy link
Collaborator Author

🎉 This PR is included in version 2.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants