Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove vendered use of peewee #41

Closed
adalke opened this issue Nov 2, 2021 · 1 comment
Closed

Remove vendered use of peewee #41

adalke opened this issue Nov 2, 2021 · 1 comment

Comments

@adalke
Copy link
Contributor

adalke commented Nov 2, 2021

mmpdb uses peewee as an adapter for different back-end databases.

I originally included a vendored version of peewee for easy of installation. I've removed that and am instead using an installation dependency on the "peewee" package.

That is, I removed peewee.py and playhouse/ and configured setup.cfg to have a installation dependency on peewee >= 3.0.

Turns out the peewee API changed from 2.x to 3.x, which occurred in 2018. A plus side of vendoring is that mmpdb was isolated from this change so we didn't have to worry about it until now. :)

I've updated mmpdb to work with the new peewee API.
@adalke
Copy link
Contributor Author

adalke commented Nov 2, 2021

This is implemented in the current 3.0 branch.

@adalke adalke closed this as completed Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adalke