Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module configuration form cannot be saved #1

Closed
rdmark opened this issue Nov 27, 2023 · 1 comment
Closed

Module configuration form cannot be saved #1

rdmark opened this issue Nov 27, 2023 · 1 comment

Comments

@rdmark
Copy link
Owner

rdmark commented Nov 27, 2023

The webmin built-in module configuration form cannot be saved. When hitting the save button, the webapp gets stuck in an endless loading cycle.

@rdmark
Copy link
Owner Author

rdmark commented Dec 9, 2023

Fixed with f4059fd

It turns out that the config-lib.pl library (part of webmin core) doesn't like it when the core module library calls ReadParse. It has to be called in each relevant cgi script instead. More details in https://forum.virtualmin.com/t/endless-loop-in-foreign-require/123882

It would be nice if the webmin API threw an error instead of ending up in an endless loop, however...

@rdmark rdmark closed this as completed Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant