Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<spring-board> should have a :host display style of block #5

Closed
rdmurphy opened this issue Jul 2, 2022 · 2 comments 路 Fixed by #8
Closed

<spring-board> should have a :host display style of block #5

rdmurphy opened this issue Jul 2, 2022 · 2 comments 路 Fixed by #8
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@rdmurphy
Copy link
Owner

rdmurphy commented Jul 2, 2022

This risks dipping into Spring '83 spec territory, but in my limited experience I've yet to find a reason for <spring-board> to not default to display: block. 馃 Setting width, height and background-color on the element doesn't really work out the box otherwise.
@rdmurphy rdmurphy added enhancement New feature or request question Further information is requested labels Jul 2, 2022
@robinsloan
Copy link

This ought to be in the specification -- I will add it to the client section of the new draft. (Honestly, I always forget that custom elements don't have display: block set; and this has caused me problems in the past!)

@rdmurphy
Copy link
Owner Author

rdmurphy commented Jul 3, 2022

Ooh, okay! This this should most certainly happen. 馃檶

@rdmurphy rdmurphy added good first issue Good for newcomers and removed question Further information is requested labels Jul 3, 2022
@rdmurphy rdmurphy changed the title <spring-board> should probably have a :host display style of block <spring-board> should have a :host display style of block Jul 3, 2022
@rdmurphy rdmurphy mentioned this issue Jul 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add display: block to :host, add reference version of default CSS rdmurphy/spring-board-element
2 participants
@robinsloan @rdmurphy