Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module maintaining #2

Open
Hipska opened this issue Mar 2, 2015 · 6 comments
Open

Module maintaining #2

Hipska opened this issue Mar 2, 2015 · 6 comments

Comments

@Hipska
Copy link

Hipska commented Mar 2, 2015

Are you planning to maintain this module and accept pull requests?

We (my company) think this is a good base, but it needs some work to be more generically useable and comply with the puppet style guides.

@helldorado
Copy link

@Hipska there is also a version of Ansible enough push here https://github.com/helldorado/cactilize.
Thank you to @brdude init for this project.

@rdrgmnzs
Copy link
Owner

rdrgmnzs commented Mar 2, 2015

@Hipska I'll try and do some work on this on the coming weekend, at least to the installation part of the module and getting it to comply with the puppet style guide.

As for the other functionality, it needs quite a bit of work to get it to where it is supposed to be. I had been waiting on cacti to release a new update with a working CLI before I could do this as having to query MySQL makes this module extremely slow. The fact that I wrote this as my first puppet module also leaves quite a bit to be desired from it. But I'll see what I can do.

@helldorado That looks awesome. I'll have to take a look at what is being done there and I might be able to pull some of that into here when I do get a change.

@Hipska
Copy link
Author

Hipska commented Mar 3, 2015

@brdude Thanks for you quick response, we can work together on that rewrite and you can find here what we already have done: https://github.com/Super-Visions/puppet-cacti/tree/feature/rewrite

@Hipska
Copy link
Author

Hipska commented Mar 9, 2015

@brdude What do you tink of our latest changes?

@Hipska
Copy link
Author

Hipska commented Mar 26, 2015

No response on this?

@rdrgmnzs
Copy link
Owner

Sorry it's been hectic over that last few weekends and I have t had a chance to go over this yet. I'm on vacation over the next two weeks and don't have access to my PC, but I'll take a look at it once I'm back home.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants