Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The execution status still green #18

Closed
BuddyGlas opened this issue Nov 29, 2022 · 1 comment
Closed

The execution status still green #18

BuddyGlas opened this issue Nov 29, 2022 · 1 comment

Comments

@BuddyGlas
Copy link

BuddyGlas commented Nov 29, 2022

Sorry, maybe I don't understand how this action should work, but I added the check to my workflow, but I didn't get the expected result. Why is the execution status (number 1 in the screenshot) still green?

  check:
    if: always()
    runs-on: [self-hosted]
    needs:
    - dev_build_int_tests

    steps:
    - name: Install python3
      uses: actions/setup-python@v4
      with:
        python-version: '3.10'

    - name: Decide whether the needed jobs succeeded or failed
      uses: re-actors/alls-green@v1.2.2
      with:
        jobs: ${{ toJSON(needs) }}

2022-11-29_14-57

@webknjaz
Copy link
Member

Sounds like you might be using something like continue-on-failure: true in those jobs, which makes GitHub set a successful outcome for them. The red crosses don't correspond to outcome but to result which may still be failing.

@re-actors re-actors locked and limited conversation to collaborators Nov 30, 2022
@webknjaz webknjaz converted this issue into discussion #19 Nov 30, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants