Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃帹 - /cryptopunks - make the background grey but transparent (opacity) when modal opens #28

Closed
nazariyv opened this issue Apr 12, 2021 · 0 comments 路 Fixed by #34
Closed

馃帹 - /cryptopunks - make the background grey but transparent (opacity) when modal opens #28

nazariyv opened this issue Apr 12, 2021 · 0 comments 路 Fixed by #34
Assignees
@sunguru98
Labels
front
Projects
Cryptopunks-Sprint-#1

Comments

@nazariyv
Copy link
Member

right now, when the modal opens, there is no background.

I recall there was, but I commented that code out because could not make the transition work. Doesn't matter. Let's just have that background without the transition
@nazariyv nazariyv added the front label Apr 12, 2021
@sunguru98 sunguru98 added this to Needs Review in Cryptopunks-Sprint-#1 Apr 12, 2021
@sunguru98 sunguru98 moved this from Needs Review to To do in Cryptopunks-Sprint-#1 Apr 12, 2021
@sunguru98 sunguru98 mentioned this issue Apr 12, 2021
Merged
@sunguru98 sunguru98 moved this from To do to Needs Review in Cryptopunks-Sprint-#1 Apr 12, 2021
@nazariyv nazariyv moved this from Needs Review to Done in Cryptopunks-Sprint-#1 Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sunguru98 sunguru98

Labels
front
Projects
No open projects
Cryptopunks-Sprint-#1
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bugfix: added a subtle modal background when modal is opened re-nft/cryptopunks
2 participants
@nazariyv @sunguru98