Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

takeUntil operator cannot complete a StateObservable #291

Closed
Jesus-Gonzalez opened this issue Dec 15, 2022 · 1 comment · Fixed by rx-state/core#19
Closed

takeUntil operator cannot complete a StateObservable #291

Jesus-Gonzalez opened this issue Dec 15, 2022 · 1 comment · Fixed by rx-state/core#19

Comments

@Jesus-Gonzalez
Copy link

Jesus-Gonzalez commented Dec 15, 2022 •
edited

Description

The takeUntil operator doesn't work when applied on a StateObservable.

Playground

To demo the bug, I have created the following playground: https://codesandbox.io/s/react-rxjs-bug-takeuntil-1-d69w72
You should expect the counter to stop incrementing when pressing the STOP button.

Environment

rxjs 7.6.0
@react-rxjs/core 0.10.3
@react-rxjs/utils 0.9.5
react 18.2.0
@voliva voliva mentioned this issue Mar 11, 2023
Merged
@voliva
Copy link
Collaborator

voliva commented Mar 11, 2023 •
edited

Thank you @Jesus-Gonzalez!

This was on the rx-state/core library. I fixed it there, and I released a patch version @react-rxjs/core@0.10.4 that has this fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: can't derive a StateObservable with takeUntil rx-state/core
2 participants
@voliva @Jesus-Gonzalez