-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: 🔧 bump react to 18.1 #170
Conversation
src/index.tsx
Outdated
@@ -41,7 +41,7 @@ openSansObserver.load().then(() => { | |||
const store = configureAppStore(); | |||
const MOUNT_NODE = document.getElementById('root') as HTMLElement; | |||
|
|||
ReactDOM.render( | |||
createRoot(MOUNT_NODE!).render( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update to replace ReactDOM
ref link
Pull Request Test Coverage Report for Build 2378171750
💛 - Coveralls |
Oops, apologies for the issue. Seems like some dependencies were not installed as required. |
Checks are failing still |
@Can-Sahin resolving this on my fork. |
@Can-Sahin @receptiryaki requesting your approval for the workflows. |
@Can-Sahin the failing (1) check is something related to commit lint pull timing out. |
@Can-Sahin @receptiryaki Requesting to look into this |
React version bump to 18.1.0
For #168
Changes: