Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 🔧 bump react to 18.1 #170

Merged
merged 5 commits into from
May 28, 2022
Merged

chore: 🔧 bump react to 18.1 #170

merged 5 commits into from
May 28, 2022

Conversation

rejochandran
Copy link
Contributor

React version bump to 18.1.0

For #168

Changes:

  • Bump React version to 18.1.0
  • Update render methods
  • Updated testing methods

src/index.tsx Outdated
@@ -41,7 +41,7 @@ openSansObserver.load().then(() => {
const store = configureAppStore();
const MOUNT_NODE = document.getElementById('root') as HTMLElement;

ReactDOM.render(
createRoot(MOUNT_NODE!).render(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update to replace ReactDOM
ref link

@coveralls
Copy link

coveralls commented May 9, 2022

Pull Request Test Coverage Report for Build 2378171750

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.678%

Totals Coverage Status
Change from base Build 2185120532: 0.0%
Covered Lines: 249
Relevant Lines: 249

💛 - Coveralls

@rejochandran
Copy link
Contributor Author

Oops, apologies for the issue. Seems like some dependencies were not installed as required.
I'll check and re-push the updates

@Can-Sahin
Copy link
Member

Checks are failing still

@rejochandran
Copy link
Contributor Author

Checks are failing still

@Can-Sahin resolving this on my fork.
WIll commit as soon as I get this up

@rejochandran
Copy link
Contributor Author

@Can-Sahin @receptiryaki requesting your approval for the workflows.
Thank you 🙂

@rejochandran
Copy link
Contributor Author

@Can-Sahin the failing (1) check is something related to commit lint pull timing out.
and all the required checks have passed.
Requesting merge if good. Thank you!

@rejochandran
Copy link
Contributor Author

@Can-Sahin @receptiryaki Requesting to look into this
All the required checks have passed. The failing check is related to commit lint pull timing out.
Would be a great help. Thank you

@Can-Sahin Can-Sahin changed the title chore(deps): bump react version to 18.1.0 with changes to deprecated methods chore: 🔧 bump react to 18.1 May 28, 2022
@Can-Sahin Can-Sahin merged commit 7ef3155 into react-boilerplate:dev May 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants