Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update webpack.base.babel.js in preparation for Webpack 2.1 release #1027

Closed
gihrig opened this issue Sep 25, 2016 · 5 comments
Closed

Update webpack.base.babel.js in preparation for Webpack 2.1 release #1027

gihrig opened this issue Sep 25, 2016 · 5 comments

Comments

@gihrig
Copy link
Contributor

gihrig commented Sep 25, 2016

Updating the webpack dependency beyond "2.1.0-beta.22" causes a build error:

Invalid configuration object

This is due an evolutionary change in Webpack. It is not a bug.

More info is at webpack #3018.

There is mention of PostCss problems as well.

I don't have time to dig into this issue ATM, it would wonderful if someone could investigate and move this forward.

OS X 10.11.6
latest react-boilerplate dev branch.

To reproduce:

  1. Update package.json "webpack": "2.1.0-beta.22" to "webpack": "2.1.0-beta.25"
  2. Run any of the following in a new clone:
    npm run setup
    npm install
    npm run build:dll
Building the Webpack DLL...
Invalid configuration object. Webpack has been initialised using a configuration object that does not match the API schema.
 - configuration has an unknown property 'progress'. These properties are valid:
   object { amd?, bail?, cache?, context?, dependencies?, devServer?, devtool?, entry, externals?, loader?, module?, name?, node?, output?, plugins?, profile?, recordsInputPath?, recordsOutputPath?, recordsPath?, resolve?, resolveLoader?, stats?, target?, watch?, watchOptions? }
   For typos: please correct them.
   For loader options: webpack 2 no longer allows custom properties in configuration.
     Loaders should be updated to allow passing options via loader options in module.rules.
     Until loaders are updated one can use the LoaderOptionsPlugin to pass these options to the loader:
     plugins: {
       new webpack.LoaderOptionsPlugin({
         // test: /\.xxx$/, // may apply this only for some modules
         options: {
           progress: ...
         }
       })
     }
 - configuration.resolve.extensions[0] should not be empty.
@veegee
Copy link

veegee commented Sep 27, 2016

I pinned my webpack version to 2.1.0-beta.20 and it works. Sigh...

@oliverturner
Copy link
Collaborator

@gihrig Given the scale of the changes between beta.22 and beta.24 my recommendation would be to pin the dependency and wait for more stability - e.g. an rc release.

@peter-mouland
Copy link
Contributor

peter-mouland commented Sep 28, 2016

the is a PR waiting to be merged for beta.25 #1032, but pinning makes sense if using a beta in prod!

@mxstbr
Copy link
Member

mxstbr commented Nov 3, 2016

Done by the amazing @peter-mouland in #1032!

@mxstbr mxstbr closed this as completed Nov 3, 2016
@lock
Copy link

lock bot commented May 30, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants