Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next version release #2129

Closed
gretzky opened this issue Feb 16, 2018 · 25 comments
Closed

Next version release #2129

gretzky opened this issue Feb 16, 2018 · 25 comments

Comments

@gretzky
Copy link
Member

gretzky commented Feb 16, 2018

React v16 is the norm now, and I feel that we need to get the next version of RBP out in order to keep up. I know that many of the maintainers / collaborators here are short on time, but I think we need some direction on when we can push a new version through and if there's any other milestones we should hit for the next version. Who's in the lead on the decision making for version releases?

There are a lot of people that rely on this project, as it's shown, and we at least need to keep up with major versioned releases as best we can. If we can get a timeline going of when to release, that would be super helpful to many people.

@torrao
Copy link

torrao commented Feb 27, 2018

Don't forget about Webpack 4 👍

@csantiago132
Copy link

Branch off development? Would like to help out

@gretzky
Copy link
Member Author

gretzky commented Feb 27, 2018

Thanks for the support, all who liked this

I'm going to move forward with a couple of things:

  • combing through all of the necessary dependency updates (react v16, webpack 4, etc)
  • revisiting the features we currently have (immutable, etc.) and evaluating the usage
  • making a branch thats spun off of create-react-app, since it would be great to have rbp follow a similar ecosystem and would take loads of work off of devs

I'll be opening multiple branches for the above and will start a new chat on Spectrum to get some more feedback and dialogue happening.

@julienben
Copy link
Member

I've just opened a pull request for Webpack 4.1.

It's been regression tested and I've deployed with it to production for my own (RBP-based) projects.

A nice benefit: The demo app's main.[hash].js has dropped from 586KB to 493KB.

@stabback
Copy link

stabback commented Mar 5, 2018

I've upgraded a couple sites that use the boilerplate to React 16, it's fairly painless. I'll open up a branch this week to address. Can I get a branch cut to start from?

@gretzky
Copy link
Member Author

gretzky commented Mar 5, 2018

@stabback The dev branch currently has v16, but I think it would be really beneficial to branch off master with a specific branch for just react v16, and we can merge into master for a minor or patch release to get it out sooner. If anyone disagrees, gimme a thumbs down, otherwise thats my opinion

@blling
Copy link

blling commented Mar 6, 2018

making a branch thats spun off of create-react-app, since it would be great to have rbp follow a similar ecosystem and would take loads of work off of devs

What is this for?

@hazelanne hazelanne mentioned this issue Mar 10, 2018
2 tasks
@michaelcuneo
Copy link

Yeah, I'm up to help on this. I really need ErrorBoundaries, sick of writing in various components and containers hitting save then spending 30 minutes going backwards finding where the Uncaught is coming from. :P What do I need to do to help.

@michaelcuneo
Copy link

I just changed the following, and got a successful build and no errors at all...
react to ^16.2.0
react-dom to 16.2.0
react-intl to ^2.4.0
react-router-dom to ^4.2.2
react-router-redux to ^5.0.0-alpha.9
enzyme to ^3.3.0
styled-components to ^3.2.1
react-test-rendered to ^16.2.0

everything builds and runs fine. No errors.

@gretzky
Copy link
Member Author

gretzky commented Mar 15, 2018

Thanks @michaelcuneo, I'm aware, just been on vacation and haven't had time to merge in just the react upgrade yet 😁

Just a side note, if you upgraded Enzyme and React, there would in fact be build errors due to Enzyme requiring adapters. See their migration guide

@julienben
Copy link
Member

Anyone have any thoughts about switching back to npm for the next version? Given that the lowest supported npm version is now 5 and it generates its own lock file, is there a reason to stick with Yarn?

@stabback
Copy link

stabback commented Apr 8, 2018

Whatever the choice, so long as it's consistent. Personally I user yarn, but just to save keystrokes. I can't remember which, but saw another repo stick to npm throughout the docs with the assumption that those who use yarn will know how to substitute it.

@julienben
Copy link
Member

julienben commented Apr 8, 2018

Do we know if there's any specific reason to stick with yarn though? Besides personal habits or "saving keystrokes" ;)

Anything we take advantage of in yarn which isn't in npm?

Also, should we try to summarize what we want to do for the next release?

From @gretzky's message above, I see:

  1. combing through all of the necessary dependency updates (react v16, webpack 4, etc)
  2. revisiting the features we currently have (immutable, etc.) and evaluating the usage
  3. making a branch thats spun off of create-react-app, since it would be great to have rbp follow a similar ecosystem and would take loads of work off of devs

IMO:

  • For 1, we could do babel and eslint upgrades but otherwise everything's done (not counting easy upgrades like react 16.2 -> 16.3, webpack 4.4 -> webpack 4.5 and the likes)
  • 2 needs to be fleshed out. Which tools are we reconsidering?
  • 3 seems like a huge project. Has anybody tried working on that? Should it be reconsidered for a 4.0 release?

@gkarwchan
Copy link

gkarwchan commented Apr 16, 2018

Hi Folks
I am new here, and I love react-boilerplate.
I spent good time upgrading to webpack 4, and then I found that the branch "dev" already did.
Beside it has react 16, and the latest Enzyme.
I am wondering what we are waiting to merge dev to master.
Dev seems good to me
Any release date?

@julienben
Copy link
Member

julienben commented Apr 16, 2018

Hey @gkarwchan, As you can read above there's a few things that need to be worked on before react-boilerplate is ready for its next release. Feel free to fork the repo and prepare a PR if you'd like to help things move faster.

@gkarwchan
Copy link

@julienben I am trying to figure out what are the few things that need work?
are we talking about these :

  1. combing through all of the necessary dependency updates (react v16, webpack 4, etc)
  2. revisiting the features we currently have (immutable, etc.) and evaluating the usage

For Number 1, I will do it to update to the latest of all dependencies.

For Number 2, I think we need more info on that

I will start working on number 1

@gkarwchan
Copy link

@gretzky @julienben
Hi
I created a PR, after I updated all dependencies except Redux

@julienben
Copy link
Member

@gkarwchan See your PR thread.

@gkarwchan
Copy link

Thanks @julienben I will fix that. you guys are using old node on the build server.

@siarheipashkevich
Copy link

Hello,
Could you please say when will be the next release of the RB?

@julienben
Copy link
Member

julienben commented Apr 22, 2018

There is no planned release date right now and spamming this thread won't make things move faster.

You're more than welcome to start your project using the dev branch btw.

@gretzky
Copy link
Member Author

gretzky commented Apr 25, 2018

I'm gonna close this in favor of @julienben dropping the hammer 🔨. As of now, there are really only 2 of us (myself and @julienben) that are around to review PRs and respond to issues, and I'm spread pretty thin right now as is. We're moving as quickly as we can! Anyone is welcome to open PRs / RFC issues

@gretzky gretzky closed this as completed Apr 25, 2018
@michaelcuneo
Copy link

I’m happy to run through PR’s for you guys as this progresses.

@julienben
Copy link
Member

The problem right now is not really reviewing PRs. It's more about the lack of quality PRs and of reaction when changes are requested.

@lock
Copy link

lock bot commented May 28, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

9 participants