Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HomePage.react.js eslint errors #23

Closed
mxstbr opened this issue Dec 17, 2015 · 4 comments · Fixed by #43
Closed

HomePage.react.js eslint errors #23

mxstbr opened this issue Dec 17, 2015 · 4 comments · Fixed by #43
Assignees

Comments

@mxstbr
Copy link
Member

mxstbr commented Dec 17, 2015

eslint current shows the following errors in HomePage.react.js in Atom:

Expected indentation of 2 space characters but found 0.

for lines 13, 14 and 15. Which doesn't make any sense, they aren't indented differently from the rest. If you change it to two spaces, the errors go away, but 4 are needed for it to look the way it should. No idea why that happens...

@mxstbr
Copy link
Member Author

mxstbr commented Dec 19, 2015

Could be related to eslint/eslint#4372, if it is eslint@2.0.0-alpha-1 fixes the issue. Taking a look...

@mxstbr mxstbr self-assigned this Dec 19, 2015
@mxstbr
Copy link
Member Author

mxstbr commented Dec 19, 2015

I've fixed it by updating to eslint 2.0, but that release is currently in alpha status. I've pushed the eslint2 branch which has the updated .eslintrc (the structure has changed in a breaking way) and there are no eslint errors at all.

I don't feel comfortable forcing everybody to globally install a package in alpha status, so I'll leave the errors for now, leave the issue open and wait for the eslint 2.0 release.

@mxstbr
Copy link
Member Author

mxstbr commented Dec 24, 2015

Tiny update: eslint responded on twitter, they are targeting early jan for the 2.0 release. https://twitter.com/geteslint/status/679003873168625664

@lock
Copy link

lock bot commented May 30, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant