Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unmet peer dependencies with React 18 #34

Closed
nixjs opened this issue Jun 3, 2022 · 8 comments
Closed

Unmet peer dependencies with React 18 #34

nixjs opened this issue Jun 3, 2022 · 8 comments

Comments

@nixjs
Copy link

nixjs commented Jun 3, 2022

I have a issues when use redux-injectors with React ^18.

image

@abesto
Copy link

abesto commented Jun 3, 2022

FWIW I've just tested 2.0.0 with React 18 and react-redux 8.0.1, and things seem to be working fine AFAICT. Possibly React 18 compatibility is a no-op (and just needs the peer dependencies to be bumped), but I don't think I use all the advanced features of redux-injectors, so grain of salt.

@avx99
Copy link

avx99 commented Sep 25, 2022

@nixjs did u solve this issue?

@nixjs
Copy link
Author

nixjs commented Sep 26, 2022

@nixjs did u solve this issue?

i still have the above problem

@nixjs
Copy link
Author

nixjs commented Sep 26, 2022

@nixjs did u solve this issue?

I think update package.json in redux-injectors:

"peerDependencies": {
    "react": "^16.6.0 || ^17.0.0 || ^18.0.0",
    "react-dom": "^16.6.0 || ^17.0.0 || ^18.0.0"
  }

instead of:

"peerDependencies": {
    "react": "^16.6.0 || ^17.0.0",
    "react-dom": "^16.6.0 || ^17.0.0"
  }

The problem will be solved.

@nixjs
Copy link
Author

nixjs commented Oct 18, 2022

When do you upgrade new version to support react v18?

@nixjs
Copy link
Author

nixjs commented Nov 9, 2022

When do you upgrade new version to support react v18?

I forked and supported react v18: https://www.npmjs.com/package/@nixjs23n6/redux-injectors

@carmenates09
Copy link

@nixjs Nice Job! I hope some day redux-injectors do something like you did in your fork, basically using > and < between versions.

@BenLorantfy
Copy link
Collaborator

This is fixed in 2.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants