Skip to content

Commit

Permalink
fix: remove navigation role from breadcrumb (#3380)
Browse files Browse the repository at this point in the history
  • Loading branch information
bpas247 authored and taion committed Dec 5, 2018
1 parent 8f76314 commit 1ac53ad
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
1 change: 0 additions & 1 deletion src/Breadcrumb.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ class Breadcrumb extends React.Component {
return (
<Component aria-label={label} className={className} {...props}>
<ol
role="navigation"
{...listProps}
className={classNames(bsPrefix, listProps.className)}
>
Expand Down
4 changes: 2 additions & 2 deletions test/BreadcrumbSpec.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@ describe('<Breadcrumb>', () => {
.should.have.length(1);
});

it('Should have a navigation role', () => {
it('Should not have a navigation role', () => {
mount(<Breadcrumb className="custom-one custom-two" />)
.find('ol[role="navigation"]')
.should.have.length(1);
.should.have.length(0);
});

it('Should have an aria-label in ol', () => {
Expand Down

0 comments on commit 1ac53ad

Please sign in to comment.