fix(Collapse): remove 0px menu height on resize and expand/collapse (#…

…3687)
react-bootstrap · Apr 23, 2019 · 787a19e · 787a19e
1 parent 3b78144
commit 787a19e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/Collapse.js b/src/Collapse.js
@@ -163,7 +163,7 @@ class Collapse extends React.Component {
   };
 
   handleExiting = elem => {
-    elem.style[this.getDimension()] = '0';
+    elem.style[this.getDimension()] = null;
   };
 
   // for testing

diff --git a/test/CollapseSpec.js b/test/CollapseSpec.js
@@ -130,7 +130,7 @@ describe('<Collapse>', () => {
       assert.equal(node.style.height, '');
 
       wrapper.setState({ in: false });
-      assert.equal(node.style.height, '0px');
+      assert.equal(node.style.height, '');
     });
 
     it('Should transition from collapsing to not collapsing', done => {
@@ -146,11 +146,11 @@ describe('<Collapse>', () => {
       assert.equal(node.className, 'collapsing');
     });
 
-    it('Should have 0px height after transition complete', done => {
+    it('Should have no height after transition complete', done => {
       let node = wrapper.getDOMNode();
 
       function onExited() {
-        assert.ok(node.style.height === '0px');
+        assert.equal(node.style.height, '');
         done();
       }