Skip to content

Commit

Permalink
fix: Popover placement prop-types to correct list of props
Browse files Browse the repository at this point in the history
Previously, it was believed that the Popover.js props is the native
behavior of the Popover bootstrap upstream component. However,
the prop-types of the `placement` props should only be of types:
- auto
- top
- bottom
- left
- right
as per the bootstrap upstream docs.
getbootstrap.com/docs/4.0/components/popovers/
  • Loading branch information
bpas247 committed Jul 6, 2019
1 parent 49a4563 commit 7c0c490
Showing 1 changed file with 1 addition and 17 deletions.
18 changes: 1 addition & 17 deletions src/Popover.js
Expand Up @@ -26,23 +26,7 @@ const propTypes = {
*
* > This is generally provided by the `Overlay` component positioning the popover
*/
placement: PropTypes.oneOf([
'auto-start',
'auto',
'auto-end',
'top-start',
'top',
'top-end',
'right-start',
'right',
'right-end',
'bottom-end',
'bottom',
'bottom-start',
'left-end',
'left',
'left-start',
]),
placement: PropTypes.oneOf(['auto', 'top', 'bottom', 'left', 'right']),

/**
* An Overlay injected set of props for positioning the popover arrow.
Expand Down

0 comments on commit 7c0c490

Please sign in to comment.