Skip to content

Commit

Permalink
fix(types): defaultActiveKey to NavProps in Nav.d.ts (#3638)
Browse files Browse the repository at this point in the history
Open issue #3623

The [documentation for the Nav component](https://react-bootstrap.netlify.com/components/navs) lists `defaultActiveKey` as a supported property.

In this case I didn't add a specific type for Typescript but instead just used the existing type for `activeKey` from `NavProps`. This matches the typing of `Tab.d.ts`
  • Loading branch information
cbzehner authored and jquense committed Apr 12, 2019
1 parent 4058ff1 commit 8819727
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions types/components/Nav.d.ts
Expand Up @@ -10,6 +10,7 @@ export interface NavProps {
cardHeaderBsPrefix?: string;
variant?: 'tabs' | 'pills';
activeKey?: unknown;
defaultActiveKey?: unknown;
fill?: boolean;
justify?: boolean;
onSelect?: SelectCallback;
Expand Down

0 comments on commit 8819727

Please sign in to comment.