Skip to content

Commit

Permalink
fix: add missing props to Navbar.Collapse (#3519)
Browse files Browse the repository at this point in the history
I tried testing this change in a dependent project, but installing the package from local clone just results in `Cannot find module 'react-bootstrap/Navbar'`. To complicate matters, the build setup seems closely tied to the contributors' development environment. The second commit in this PR fixes the build from a clean state; it only ever worked from a dirty state. There is no `prepare` NPM script: is that intentional?

At the least, this can serve as a starting point.

/cc @jquense
  • Loading branch information
thejohnfreeman authored and jquense committed Mar 6, 2019
1 parent 6f03223 commit dd75d22
Showing 1 changed file with 9 additions and 2 deletions.
11 changes: 9 additions & 2 deletions types/components/NavbarCollapse.d.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,16 @@
import * as React from 'react';

import Collapse from './Collapse';
import Collapse, { CollapseProps } from './Collapse';

import { BsPrefixComponent } from './helpers';

declare class NavbarCollapse extends BsPrefixComponent<typeof Collapse> {}
export interface NavbarCollapseProps
extends CollapseProps,
React.HTMLAttributes<HTMLDivElement> {}

declare class NavbarCollapse extends BsPrefixComponent<
typeof Collapse,
NavbarCollapseProps
> {}

export default NavbarCollapse;

0 comments on commit dd75d22

Please sign in to comment.