Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onSlideEnd in the Carousel is never called #3405

Closed
glenjamin opened this issue Dec 30, 2018 · 2 comments
Closed

onSlideEnd in the Carousel is never called #3405

glenjamin opened this issue Dec 30, 2018 · 2 comments

Comments

@glenjamin
Copy link
Collaborator

I spotted this while going through adding the types and I was checking for the argument signature.

As far as I can tell, there's no code to ever call this callback.
@taion
Copy link
Member

taion commented Dec 30, 2018

Should we just get rid of it?

@tommyalvarez
Copy link

@taion no, it should be implemented i think.

@mxschmitt mxschmitt mentioned this issue Mar 4, 2019
Merged
@taion taion closed this as completed in b836c9c Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@glenjamin @tommyalvarez @taion