Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table bordered=false does not disable borders #3470

Closed
dpisklov opened this issue Feb 15, 2019 · 4 comments

Comments

@dpisklov
Copy link
Contributor

@dpisklov dpisklov commented Feb 15, 2019

Bootstrap has explicit styling for borderless table. If neither table-bordered or table-borderless it defaults to semi-bordered version (with horizontal borders dividing header).
There should be a way to use table-borderless class. At the moment it's either table-bordered or nothing, according to Table.js:

      bordered && `${bsPrefix}-bordered`,
@taion

This comment has been minimized.

Copy link
Member

@taion taion commented Feb 15, 2019

We'd happily take a PR for this.

dpisklov added a commit to dpisklov/react-bootstrap that referenced this issue Feb 15, 2019
@dpisklov

This comment has been minimized.

Copy link
Contributor Author

@dpisklov dpisklov commented Feb 15, 2019

@taion done #3473

@taion

This comment has been minimized.

Copy link
Member

@taion taion commented Feb 15, 2019

thanks!

@jquense jquense closed this in 22e9316 Feb 15, 2019
@dpisklov

This comment has been minimized.

Copy link
Contributor Author

@dpisklov dpisklov commented Feb 15, 2019

@taion @jquense thanks for a quick turnaround - when can I expect a release with this change included?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.