-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Spinners #3541
Add support for Spinners #3541
Conversation
…ion to Bootstrap 4.2 CSS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool! can we add a type signature as well, for the TS users?
I'll add it now. |
Thanks! |
this is awesome |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super duper fast, good Job!
@taion I've added the Typescript support. I don't have the deepest understanding of the way the Typescript definitions are structured for this project so it might be worth just checking the details of my implementation. |
Any news when beta 6 will be released so we can use these without pulling in master ? :) |
soon! |
Adds support for the spinners components introduced in Bootstrap 4.2.
Changes:
Spinner
componentNotes:
animation
was chosen at it was the most representative of the changes the property made, but I feel it may still be too ambiguous. I'm open to alternative suggestions.