fix(types): add bootstrap sizes for Form.Label as column #3731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jquense
reviewed
May 2, 2019
types/components/FormLabel.d.ts
Outdated
|
|
||
| export interface FormLabelProps { | ||
| export interface FormLabelProps extends ColProps { |
There was a problem hiding this comment.
I wonder if the right way to do this is via a type Union, e.g. FormLabel | FormLabelWithColProps there column is true or false specifically (instead of boolean) to allow TS to differentiate
There was a problem hiding this comment.
I started to do that, but didn't see that throughout the other typings so I wasn't sure if there was a preferred style. Let me write it up with the type Union.
jquense
reviewed
May 2, 2019
|
one thing to note is that since |
taion
approved these changes
May 2, 2019
|
@jquense I think this should be good to go now. |
taion
approved these changes
May 6, 2019
jquense
approved these changes
May 21, 2019
jquense
changed the title
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if just extending
FormLabelPropswithColPropsis the preferred way to solve this issue or if you would want something that actually enforces that the column size props are only valid whencolumnistrue.I can make the typing stricter if that's preferred. It also seems like generally types aren't imported around and reused so if that's a problem I can copy them over completely from
Col.d.ts