feat: modulate Popover Components #3811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
start work on decoupling and modulating the popover components to their own respective components. This will allow the users to choose how they want the popovers to be displayed, whether they want a title, no title, or if they want to inject their own custom title. also start work on changing the popover docs to reflect this new behavior. also start work on updating the popover unit tests to reflect this new behavior
this issue was caused by the HOC function not carrying over the properties of the function, which were the modulated popover components.
add a shorthand syntax for declaring a popover with no title. also fix bsPrefix issues with PopoverTitle and PopoverContent
the actual children prop i don't know how i missed this 👀
|
So I'm a bit confused on what I should do for the react-bootstrap/src/PopoverTitle.js Line 13 in f6845d7 Should I just remove it and have the users inject their own tag via EDIT: this is what I ended up doing in 7efa7df |
this should be applied based on the user's preference, via className
|
Actually, the |
this will allow users to define a custom element type for their Popover components (such as setting PopoverTitle to use an 'h3' element)
Update Popover examples to utilize new `as` prop on `PopoverTitle` Co-Authored-By: Jimmy Jia <tesrin@gmail.com>
taion
approved these changes
May 31, 2019
|
Is there anything keeping this PR from being merged? |
jquense
approved these changes
Jun 21, 2019
jquense
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow users more customization regarding the Popover component.
Fixes #2449.