Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AbstractNav): Re-add role attribute to abstract nav #4331

Merged
merged 2 commits into from
Aug 24, 2019
Merged

fix(AbstractNav): Re-add role attribute to abstract nav #4331

merged 2 commits into from
Aug 24, 2019

Conversation

jmooserific
Copy link
Contributor

Due to changes made in #4031, AbstractNav now needs to explicitly pass role down to Component.

Fixes issue reported in #4313.

Updated tests to catch the problem.

Copy link
Member

@mxschmitt mxschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can also use props.role instead of role in line 123. So we can get rid of the extra prop in line 133.

Copy link
Member

@taion taion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think having role explicitly spread out in the signature makes it more clear that it's used, and we do often explicitly pass through props in this manner, too.

@taion taion merged commit 6c2dd84 into react-bootstrap:master Aug 24, 2019
@jmooserific jmooserific deleted the re-add_role_attribute_to_abstract_nav branch August 24, 2019 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants