Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Purpose of type defaultProps in FormCheckLabel? #4335

Closed
JeromeDeLeon opened this issue Aug 25, 2019 · 4 comments
Closed

Purpose of type defaultProps in FormCheckLabel? #4335

JeromeDeLeon opened this issue Aug 25, 2019 · 4 comments
Labels
difficulty: easy PR welcome

Comments

@JeromeDeLeon
Copy link
Contributor

No description provided.

@JeromeDeLeon JeromeDeLeon changed the title purpose of type attribute in FormCheckLabel? Purpose of type prop in FormCheckLabel? Aug 25, 2019
@bpas247
Copy link
Member

bpas247 commented Aug 25, 2019

Purpose of type prop in FormCheckLabel?

FormCheckLabel doesn’t have a type prop.
https://react-bootstrap.github.io/components/forms/#form-check-label-props

@bpas247 bpas247 added needs more info Issue requires more information from poster question labels Aug 25, 2019
@JeromeDeLeon
Copy link
Contributor Author

yes you're right but instead in the code you have defaultProps that contains type with a value of checkbox.

@JeromeDeLeon
Copy link
Contributor Author

react-bootstrap/src/FormCheckLabel.js

Lines 24 to 26 in ac71788

const defaultProps = {
type: 'checkbox',
};

@JeromeDeLeon JeromeDeLeon changed the title Purpose of type prop in FormCheckLabel? Purpose of type defaultProps in FormCheckLabel? Aug 26, 2019
@taion
Copy link
Member

taion commented Aug 26, 2019

That looks like a mistake. We'd be happy to take a PR removing it.

@mxschmitt mxschmitt added difficulty: easy PR welcome and removed needs more info Issue requires more information from poster question labels Aug 26, 2019
@JeromeDeLeon JeromeDeLeon mentioned this issue Aug 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: easy PR welcome
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@taion @mxschmitt @bpas247 @JeromeDeLeon