fix(TabContainer): Resolve lifecycle deprecation #4370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
note the CI junk around lint though \: |
taion
reviewed
Aug 30, 2019
| '`generateChildId` prop to TabContainer is required', | ||
| ); | ||
| } | ||
| /* eslint-disable react/no-unused-prop-types */ |
There was a problem hiding this comment.
@jquense bleh, is there a better way to do this? alternatively, why isn't this triggering for e.g. <Alert>? does this rule just not work for React.forwardRefs?
There was a problem hiding this comment.
hah, i guess it just doesn't work for ForwardRef things...
There was a problem hiding this comment.
It does work for forwardRef, just not for prop spread. If a component spreads props into a child, the lint rule passes:
const Alert = _props => <div {...{}} />;Most forwardRef components also spread remainder props, so they already trigger this behavior.
bpas247
approved these changes
Aug 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
uncontrollablewith equivalentuseUncontrolled.Fixes #4368.