fix(Table): allow passed in refs to be properly forwarded #4592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taion
approved these changes
Oct 4, 2019
| ...props | ||
| } = this.props; | ||
|
|
||
| ...otherProps |
There was a problem hiding this comment.
just ...props i think... unless there’s a name collision
There was a problem hiding this comment.
It certainly could be. Mostly I was following a different example (https://github.com/react-bootstrap/react-bootstrap/pull/3992/files) that also had otherProps, and to at least delineate that it is other props than what is being used with this stuff.
Would require a change here, and a change on line 84.
There was a problem hiding this comment.
let’s do that. the example there already has a props so we needed another name
13 tasks
bpas247
approved these changes
Oct 5, 2019
mxschmitt
changed the title
forwardRef
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4194
Updates Table component to play nice with a passed ref.