Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Overlay Trigger to support flip property #4660

Merged
merged 2 commits into from
Oct 14, 2019
Merged

Updated Overlay Trigger to support flip property #4660

merged 2 commits into from
Oct 14, 2019

Conversation

Tarun047
Copy link
Contributor

Fixes #4262

taion
taion approved these changes Oct 11, 2019
View reviewed changes
Copy link
Member

@taion taion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we may need this in the TS defs as well.

@Tarun047
Copy link
Contributor Author

Updated TS defs as well to support flip property

@jquense jquense merged commit ed77ae7 into react-bootstrap:master Oct 14, 2019
@jquense
Copy link
Member

jquense commented Oct 14, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxschmitt mxschmitt mxschmitt approved these changes

@taion taion Awaiting requested review from taion

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add flip prop to Overlay(Trigger)
4 participants
@Tarun047 @jquense @taion @mxschmitt