New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type of Overlay's onHide prop #4857

Merged

jquense merged 1 commit into react-bootstrap:master from dsgkirkby:master

Nov 24, 2019

Contributor

dsgkirkby commented Nov 22, 2019

The type is incorrect, and is a regression from v0.x; react-overlays supplies the event to the onHide callback.

Reference:

onHide is called from the useRootClose hook: https://github.com/react-bootstrap/react-overlays/blob/master/src/Overlay.js#L74
useRootClose passes the event to the onClose function: https://github.com/react-bootstrap/react-overlays/blob/master/src/useRootClose.js#L59


          Fix type of Overlay's onHide prop

befeaca

taion approved these changes

View reviewed changes

jquense approved these changes

View reviewed changes

jquense merged commit d616175 into react-bootstrap:master

Member

jquense commented Nov 24, 2019

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment