Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Feedback): Add support for tooltips #5189

Merged
merged 2 commits into from
May 19, 2020

Conversation

kyletsang
Copy link
Member

Resolves #5188

src/FormCheck.js Outdated Show resolved Hide resolved
@jquense jquense merged commit 59b1fce into react-bootstrap:master May 19, 2020
@jquense
Copy link
Member

jquense commented May 19, 2020

awesome thank you!

@kyletsang kyletsang deleted the form-feedback-tooltips branch May 29, 2020 17:41
@shaungc-su
Copy link

shaungc-su commented Jun 23, 2020

Nice work, looking forward to using the tooltip variant! Wondering would this be included in the next release like 1.1.0? Looks like it's not yet included inv1.1.0-rc.0.

@kyletsang
Copy link
Member Author

Nice work, looking forward to using the tooltip variant! Wondering would this be included in the next release like 1.1.0? Looks like it's not yet included inv1.1.0-rc.0.

@taion?

@taion
Copy link
Member

taion commented Jun 24, 2020

@kyletsang looks like @jquense is already setting up for 1.1.0 in #5251, so maybe we just wait until then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add FormControl.Feedback tooltip variant
4 participants