Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Button): Use type attribute if specified #5208

Merged
merged 2 commits into from
Jun 15, 2020
Merged

fix(Button): Use type attribute if specified #5208

merged 2 commits into from
Jun 15, 2020

Conversation

kyletsang
Copy link
Member

Fixes #4762

@taion
Copy link
Member

taion commented Jun 1, 2020

eh, though, see #4762 (comment)

@kyletsang kyletsang changed the title fix(Button): Apply type attribute if "as" is an input fix(Button): Use type attribute if specified Jun 15, 2020
@kyletsang
Copy link
Member Author

Can I merge this @taion ?

@taion
Copy link
Member

taion commented Jun 15, 2020

yes please do!

@kyletsang kyletsang merged commit 426b6da into react-bootstrap:master Jun 15, 2020
@kyletsang kyletsang deleted the fix/button-input-type branch June 18, 2020 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kosmiq kosmiq kosmiq approved these changes

@taion taion taion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Button as input does not set type attribute
3 participants
@kyletsang @taion @kosmiq