fix(Overlay): Fix types and overlay example #5275
Conversation
| @@ -17,9 +17,13 @@ export interface OverlayInjectedProps { | |||
| style: React.CSSProperties; | |||
| 'aria-labelledby'?: string; | |||
|
|
|||
| arrowProps: { ref: any; style: object }; | |||
| arrowProps: { | |||
| ref: React.RefCallback<HTMLElement>; | |||
There was a problem hiding this comment.
are we explicitly expecting this to be a ref callback? why can't it just be typed as any valid ref?
There was a problem hiding this comment.
This is typed to match that of upstream react-overlays
There was a problem hiding this comment.
okay well I don't understand why the types for react-overlays is that way either 😛 it should be allowed to pass in any valid refs for that feature.
But this is something we'd have to fix in react-overlays first so for now it makes sense for them to be the same type.
There was a problem hiding this comment.
Agreed. I was wondering about the ref typing as well, but didn't have enough time for a deep dive into RO today.
There was a problem hiding this comment.
Double checked RO and the type is correct. It always passes a callback ref.
Resolves #4717