Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix clearing nextDirectionRef in <Carousel> #5322

Merged
merged 3 commits into from
Aug 5, 2020
Merged

fix: Fix clearing nextDirectionRef in <Carousel> #5322

merged 3 commits into from
Aug 5, 2020

Conversation

taion
Copy link
Member

@taion taion commented Jul 22, 2020

Fixes #5319

@taion taion mentioned this pull request Jul 22, 2020
Closed
@taion taion requested review from kyletsang and jquense July 22, 2020 19:22
kyletsang
kyletsang reviewed Jul 22, 2020
View reviewed changes
src/Carousel.tsx Outdated Show resolved Hide resolved
@taion taion mentioned this pull request Aug 5, 2020
Closed
@taion taion requested a review from kyletsang August 5, 2020 17:19
@taion taion merged commit 5c5ea8d into master Aug 5, 2020
@taion taion deleted the carousel-nextdirection branch August 5, 2020 19:03
@cjmaret
Copy link

cjmaret commented Apr 1, 2022

this issue still exists for me

@deumolo
Copy link

deumolo commented Jun 29, 2023

Was this ever solved ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyletsang kyletsang kyletsang approved these changes

@jquense jquense Awaiting requested review from jquense

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Carousel is not correctly sliding from first index to last in 'prev' direction
4 participants
@taion @cjmaret @deumolo @kyletsang