Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5: Update Badge classes #5389

Merged
merged 1 commit into from
Aug 28, 2020
Merged

v5: Update Badge classes #5389

merged 1 commit into from
Aug 28, 2020

Conversation

thakkaryash94
Copy link
Contributor

[ x ] Change .badge-variant class to .bg-variant
[ x ] Change .badge-pill class to .rounded-pill

Link: https://github.com/react-bootstrap/react-bootstrap/projects/2#card-42008293

New request from: #5345

@kyletsang
Copy link
Member

Since all of these badge changes are now using util classes (border, bg color, text color), I'm thinking we should address this after #5373 is done.

@bpas247 what do you think?

@bpas247
Copy link
Member

bpas247 commented Aug 28, 2020

Since all of these badge changes are now using util classes (border, bg color, text color), I'm thinking we should address this after #5373 is done.

Hmm, that's a tough call since that PR isn't going to be done for awhile 🤔 not sure if I want this to be blocked for that long.

Maybe we could merge this (pending approval) and we'll just rebase in #5373 accordingly?

Worst-case scenario some (or all) of the work that's done here will get deprecated later on 😛

@jquense
Copy link
Member

jquense commented Aug 28, 2020

ya lets merge this in, if we have larger changes that affect this later no big deal 👍

@kyletsang kyletsang merged commit 651ae24 into react-bootstrap:bs5-dev Aug 28, 2020
@kyletsang kyletsang added this to In Progress in v5 support via automation Aug 28, 2020
@kyletsang kyletsang moved this from In Progress to Done in v5 support Aug 28, 2020
@thakkaryash94
Copy link
Contributor Author

Thank you everyone for your support

@bpas247
Copy link
Member

bpas247 commented Aug 29, 2020

Absolutely 😄 thank you for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
v5 support
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants