New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allow falsy eventKeys in DropdownItem and ListGroupItem #5404

Merged

kyletsang merged 1 commit into react-bootstrap:master from kyletsang:fix/makeeventkey-string

Aug 26, 2020

Member

kyletsang commented Aug 25, 2020

Fixes #5401

I kept the TS type for eventKey as string in DropdownItem since it's been this way back in Aug 2019.


          fix: Allow falsy eventKeys in DropdownItem and ListGroupItem

f804f4d

jquense approved these changes

View reviewed changes

kyletsang merged commit f493a15 into react-bootstrap:master

kyletsang deleted the fix/makeeventkey-string branch

August 26, 2020 17:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment