Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with react-bootstrap/carousel -- Clicking on the Carousel indicators, arrows stops the auto looping in iphone #5431

Closed
chandru14 opened this issue Sep 12, 2020 · 5 comments · Fixed by #5435
Labels

Comments

@chandru14
Copy link

chandru14 commented Sep 12, 2020

Hi,
The click of arrows stops the auto looping of the carousel.
Steps to reproduce:

  1. open the https://react-bootstrap.github.io/components/carousel/ in chrome inspector and select iPhone X mode
  2. Click on any of the arrows (prev/next/) or the indicators at the bottom of the carousel - it moves to the slide and then stops the looping.

Any quick help would be appreciated.

@chandru14 chandru14 changed the title Clicking on the Carousel indicators, arrows stops the auto looping in iphone Issue with react-bootstrap/carousel -- Clicking on the Carousel indicators, arrows stops the auto looping in iphone Sep 12, 2020
@kyletsang
Copy link
Member

Looks like pausedOnTouch is not getting reset due to an early return here:

if (Math.abs(touchDeltaX) <= SWIPE_THRESHOLD) {
return;
}

A single tap anywhere on the carousel would pause it.

@IsbahAhmed
Copy link

can you tell me how to stop auto looping of carousel?

@chandru14
Copy link
Author

can you tell me how to stop auto looping of carousel?

Add the attribute interval and set to null to the Carousel tag
(you will find it in the https://react-bootstrap.github.io/components/carousel/
API section of carousel table)

@chandru14
Copy link
Author

Hi,
The click of arrows stops the auto looping of the carousel.
Steps to reproduce:

  1. open the https://react-bootstrap.github.io/components/carousel/ in chrome inspector and select iPhone X mode
  2. Click on any of the arrows (prev/next/) or the indicators at the bottom of the carousel - it moves to the slide and then stops the looping.

Any quick help would be appreciated.

Hi,
is the issue fixed?
Can anyone help on this.

@kyletsang
Copy link
Member

@chandru14, there is an open PR for this at #5435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants