fix(Button): display variant only when set #5458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bugfix aligns the `<button>` variant class implementation with Alert/Badge/Navbar -- only outputing a `prefix-variant` formatted class when a variant is specified and avoiding the situation of outputting `.btn-null` or `.btn-` when the variant is null or an empty string respectively Split from react-bootstrap#5456
jquense
approved these changes
Oct 1, 2020
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bugfix aligns the
<button>variant class implementation with Alert/Badge/Navbar -- only outputing aprefix-variantformatted class when a variant is specified and avoiding the situation of outputting.btn-nullor.btn-when the variant is null or an empty string respectively.This adds several tests to confirm that the default variant gets removed but also the invalid variants don't get outputted.
Split from #5456