docs(CloseButton): add component page #5474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyletsang
reviewed
Oct 13, 2020
davidjb
force-pushed
the
v5-close-button-docs
branch
from
5b8b7bb
to
086bb16
Compare
|
Thanks for the review @kyletsang - all changes made and pushed into this PR |
kyletsang
approved these changes
Oct 14, 2020
|
Thanks! |
kyletsang
added a commit
that referenced
this pull request
Dec 9, 2020
* feat(v5): Update CloseButton - Added white variant - Remove inner span label in favor of aria-label attrib - Remove inner × label since it's now using a built-in svg - Enable CloseButton tests (previously not working) - Added closeVariant prop to Alert, ToastHeader, ModalHeader * docs(CloseButton): add component page (#5474) Co-authored-by: David Beitey <david@davidjb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #5468. Some adjustment of the TS API may be required, see below where the
variant's type is the string literal of'white'(PropTypes.oneOf[null, 'white']?):