-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(v5): Update Accordion #5517
Conversation
awesome, gonna try and get some time to take a good look at this. Ping me if i forget! |
Hey @jquense, are you avail to review some of these existing v5 PRs? I got some free time next week, so I can finish up adding the new beta changes once the existing PRs are merged in. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, small nit and API thoughts
651420f
to
2925b8e
Compare
New changes:
|
awesome. We've also come full circle to rebuilding the 5 year old Accordion component API from like bootstrap v3 |
https://v5.getbootstrap.com/docs/5.0/components/accordion/
Accordion is now its own dedicated component in v5.
Note: I left the examples for the custom-toggle card-based components just because it's still possible to create them. Might be useful down the line?
Changes:
AccordionContext
andSelectableContext
together to simplify and remove nullSelectableContext
context fix