fix(types): Set @types/react as optional peer dependency

[kyletsang]

Fixes #5541

[jquense]

I'm not sure that peer deps are the correct place for the types? only this package needs this range of types. the duplication in the issue is coming from npm/yarn not being able to reconcile and dedupe a common version. It does seem to break which isn't great but alternatively if it's a peer dep the user would still have an invalid setup trying to use the v17 types, AND npm users would get warnings saying they are missing a peer dep because peer deps meta isn't supported in npm (maybe in v7?).

not sure what the correct thing to do is...

[kosmiq]

About npm v7: It does installs peer deps by default. Npm v6 does not however.

[kyletsang]

Peer deps meta should be supported as of 6.11.0:
https://github.com/npm/cli/releases/tag/v6.11.0

This release is a lil over a year old now, so most people should be good with the peer deps meta support. Warnings might be ok otherwise, since they'll likely be seeing warnings about the jquery peer deps in bootstrap already :P

I did check the build against the react 17 types and didn't see any issues. I think it should be ok for the types to support >=16.9.35?

[ceisele-r]

Thanks @kyletsang for taking care of this. It would be super helpful to get a release with this fix once you decided on the final solution as this breaks compilation for projects trying to use react 17 types.

[jquense]

@ceisele-r it will continue to be broken with react-17 types until RB supports that version...moving it to a peer dep will only move the conflict

[jquense]

I think the initial step is just to change the normal dep to >= range to allow the 17 types and enable deduping. That is if we are actually compatible with those types

[kyletsang]

Is there a way for us to test this locally to make sure dedupe works as expected?

[jquense]

no, but it should, has up until now at least