Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(InputGroup): Add hasValidation prop #5618

Merged
merged 1 commit into from
Jan 21, 2021
Merged

feat(InputGroup): Add hasValidation prop #5618

merged 1 commit into from
Jan 21, 2021

Conversation

kyletsang
Copy link
Member

To detect what elements need rounded corners inside an input group with validation, an input group requires an additional .has-validation class.

Ref: https://getbootstrap.com/docs/4.6/components/forms/#input-group-validation

jquense
jquense approved these changes Jan 21, 2021
View reviewed changes
Copy link
Member

@jquense jquense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bleh that's an annoying quirk, too bad it couldn't be handled via CSS (upstream)

@kyletsang kyletsang merged commit fa96fec into react-bootstrap:master Jan 21, 2021
@kyletsang kyletsang deleted the feat/input-group-validation branch January 21, 2021 18:05
This was referenced Mar 10, 2021
Merged
Closed
Closed
Merged
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@dependabot dependabot bot mentioned this pull request Mar 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jquense jquense jquense approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kyletsang @jquense