fix(Popover): use Bootstrap default offsets #5663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jquense
reviewed
Feb 25, 2021
src/useOverlayOffset.tsx
Outdated
| ) { | ||
| // Default popover offset. | ||
| // https://github.com/twbs/bootstrap/blob/5c32767e0e0dbac2d934bcdee03719a65d3f1187/js/src/popover.js#L28 | ||
| return [0, 8]; |
There was a problem hiding this comment.
I think we should expose this via a module constant, maybe in Popover, just to ensure users have access to these hard coded values in case they change
There was a problem hiding this comment.
Done. Had to move ArrowProps and Placement types from Overlay over to types.tsx to fix a circular dependency warning.
jquense
reviewed
Feb 25, 2021
| @@ -166,7 +166,7 @@ function Overlay({ | |||
| ...outerProps | |||
| }: OverlayProps) { | |||
| const popperRef = useRef({}); | |||
| const [ref, marginModifiers] = usePopperMarginModifiers(); | |||
| const [ref, modifiers] = useOverlayOffset(); | |||
There was a problem hiding this comment.
hmm this API is unfortunate...ideally you'd want the the Popover component itself to specify this, might be feasible with context, but i'd be afraid of timing issues. Lets make sure we aren't calling this hook "public" in case we want to remove it later
Add offset constant into popover Move overlay types into another types.tsx to prevent circular dependency warning
jquense
approved these changes
Feb 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For bootstrap 5
Popovers are not aligned due to a missing default offset found in upstream bootstrap:
https://github.com/twbs/bootstrap/blob/5c32767e0e0dbac2d934bcdee03719a65d3f1187/js/src/popover.js#L28
The approach here uses a
useOverlayOffsethook to add the proper offset if it's a popover, otherwise default [0, 0].This is the last usage of
usePopperMarginModifiers, so we can remove that in this PR after #5662 is merged.