Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v5): update ResponsiveEmbed to Ratio #5714

Merged
merged 3 commits into from
May 12, 2021
Merged

feat(v5): update ResponsiveEmbed to Ratio #5714

merged 3 commits into from
May 12, 2021

Conversation

kyletsang
Copy link
Member

https://getbootstrap.com/docs/5.0/helpers/ratio/

ResponsiveEmbed has been changed to Ratio as per upstream. Fixed impl, tests, docs.

@kyletsang kyletsang added this to In Progress in v5 support via automation Mar 10, 2021
@kyletsang kyletsang requested a review from jquense March 31, 2021 07:02
src/Ratio.tsx Outdated Show resolved Hide resolved
@kyletsang kyletsang merged commit 91470c2 into bs5-dev May 12, 2021
v5 support automation moved this from In Progress to Done May 12, 2021
@kyletsang kyletsang deleted the v5-ratio branch May 12, 2021 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
v5 support
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants