Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Nav): add .card-header-* only if nested in card header #5720

Merged
merged 1 commit into from
Mar 16, 2021

Conversation

kyletsang
Copy link
Member

Fixes #4771 for bs5 branch

Rename CardContext to CardHeaderContext since it's only used for CardHeaders. Also added missing components into docs

Rename CardContext to CardHeaderContext since it's only used for CardHeaders
@kyletsang kyletsang added this to In Progress in v5 support via automation Mar 15, 2021
Copy link
Member

@jquense jquense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bootstrap is getting a little out of hand with these combinations

@kyletsang kyletsang merged commit 793e857 into bs5-dev Mar 16, 2021
@kyletsang kyletsang deleted the fix/card-header-nav branch March 16, 2021 17:28
v5 support automation moved this from In Progress to Done Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
v5 support
  
Done
Development

Successfully merging this pull request may close these issues.

<Nav> inside <Card> has "card-header-*" class even outside <Card.Header>
2 participants