Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Carousel): add indicatorLabels prop and fix indicator styling #5773

Merged
merged 1 commit into from
May 20, 2021

Conversation

kyletsang
Copy link
Member

Fixes #5771

Indicators were fixed to match the new markup. Also added indicatorLabels to allow for customization of the aria-label attributes in the indicator buttons.

@kyletsang kyletsang linked an issue Apr 18, 2021 that may be closed by this pull request
@kyletsang kyletsang added this to In Progress in v5 support via automation Apr 18, 2021
@kyletsang kyletsang added the Bootstrap 5 Bootstrap 5 label May 12, 2021
@kyletsang kyletsang requested a review from jquense May 19, 2021 16:37
@kyletsang kyletsang merged commit 0f7b39d into bs5-dev May 20, 2021
@kyletsang kyletsang deleted the fix/v5-carousel-indicators branch May 20, 2021 16:03
v5 support automation moved this from In Progress to Done May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bootstrap 5 Bootstrap 5
Projects
No open projects
v5 support
  
Done
Development

Successfully merging this pull request may close these issues.

Carousel Indicators styling and documentation
2 participants