Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new eslint rule object-shorthand #584

Closed
6 tasks done
AlexKVal opened this issue Apr 27, 2015 · 9 comments
Closed
6 tasks done

Implement new eslint rule object-shorthand #584

AlexKVal opened this issue Apr 27, 2015 · 9 comments
Assignees

Comments

@AlexKVal
Copy link
Member

1 NavItem.js#L32
2 Input.js#L181
3 Button.js#L34

ref: http://eslint.org/docs/rules/object-shorthand

@AlexKVal AlexKVal self-assigned this Apr 30, 2015
@dozoisch
Copy link
Member

dozoisch commented May 3, 2015

2374 seems to be fixed now!

@AlexKVal
Copy link
Member Author

AlexKVal commented May 4, 2015

Thank you, Hugo ✨
I've updated the issue progress.
Now we wait for new version release containing this fix.

@AlexKVal
Copy link
Member Author

I've added
Wait for issue eslint/eslint#2486 with es7.objectRestSpread is resolved

@AlexKVal
Copy link
Member Author

As it was expected es7.objectRestSpread rule is experimental and eslint doesn't support es7 yet.
Maybe babel-eslint monkeypatching.
It needs additional research.

@AlexKVal
Copy link
Member Author

I've done some research on babel-eslint.

The babel-eslint "monkeypatching" is not patching any rules.

Therefore it seems the only solution is to comment out those lines for now.
(or write standalone plugin with this rule working with es7, as Ilya Volodin suggests)

As for this PR:
Maybe tag it as needs dependency update ?

@mtscout6
Copy link
Member

Have you submitted the issue with babel-eslint?

@AlexKVal
Copy link
Member Author

It's useless.
babel-eslint is just kind of a sugar for AST. That's all.
It has no any connection with any rule evaluation at all.

ref: https://github.com/babel/babel-eslint/blob/master/index.js
that's all.

@mtscout6
Copy link
Member

Ah, I gotcha 😕

@AlexKVal
Copy link
Member Author

Resolved by #872
and #875

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants